Merged
Conversation
Member
Author
|
@MarcoGorelli it might seem strange doing the PR(s) in order of property - but it's helping to somewhat align the code between backends in one go I'm not looking to do it any time soon - but it seems like sharing more |
MarcoGorelli
approved these changes
Mar 25, 2025
Comment on lines
-931
to
+918
| if self._implementation is Implementation.PANDAS: | ||
| return pl.from_pandas(self.native) | ||
| elif self._implementation is Implementation.CUDF: # pragma: no cover | ||
| return pl.from_pandas(self.native.to_pandas()) | ||
| elif self._implementation is Implementation.MODIN: | ||
| return pl.from_pandas(self.native._to_pandas()) | ||
| msg = f"Unknown implementation: {self._implementation}" # pragma: no cover | ||
| raise AssertionError(msg) | ||
| return pl.from_pandas(self.to_pandas()) |
This was referenced Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Compliant*protocols #2230Checklist
If you have comments or can explain your changes, please do so below